lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0
From
Date
Hello.

On 10/22/2015 09:26 PM, Punit Vara wrote:

> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>
> -Unneeded variable: "ret". Return "0" on line 1733
>
> Remove unneccesary variable ret created to return zero.
>
> Also removed empty line suggested by Sergei
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
> index 94d34ee..0c82ea5 100644
> --- a/drivers/net/wireless/ath/ath5k/eeprom.c
> +++ b/drivers/net/wireless/ath/ath5k/eeprom.c
> @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
> struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
> u32 offset;
> u16 val;
> - int ret = 0, i;
> -

No, this one shouldn't have been removed. There should an empty line
between the declarations and the statements.

> + int i;
> offset = AR5K_EEPROM_CTL(ee->ee_version) +
> AR5K_EEPROM_N_CTLS(ee->ee_version);
>

MBR, Sergei



\
 
 \ /
  Last update: 2015-10-22 21:01    [W:0.167 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site