lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH block/for-linus] blkcg: fix incorrect read/write sync/async stat accounting
Date
Tejun Heo <tj@kernel.org> writes:

> While unifying how blkcg stats are collected, 77ea733884eb ("blkcg:
> move io_service_bytes and io_serviced stats into blkcg_gq")
> incorrectly used bio->flags instead of bio->rw to tell the IO type.
> This made IOs to be accounted as the wrong type. Fix it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Fixes: 77ea733884eb ("blkcg: move io_service_bytes and io_serviced stats into blkcg_gq")

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

> ---
> include/linux/blk-cgroup.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/include/linux/blk-cgroup.h
> +++ b/include/linux/blk-cgroup.h
> @@ -713,9 +713,9 @@ static inline bool blkcg_bio_issue_check
>
> if (!throtl) {
> blkg = blkg ?: q->root_blkg;
> - blkg_rwstat_add(&blkg->stat_bytes, bio->bi_flags,
> + blkg_rwstat_add(&blkg->stat_bytes, bio->bi_rw,
> bio->bi_iter.bi_size);
> - blkg_rwstat_add(&blkg->stat_ios, bio->bi_flags, 1);
> + blkg_rwstat_add(&blkg->stat_ios, bio->bi_rw, 1);
> }
>
> rcu_read_unlock();
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2015-10-22 16:41    [W:0.031 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site