lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled
Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> > Hi Ingo,
> >
> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> * Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >>> The caller callchain order is useful with --children option since it can
> >>> show 'overview' style output, but other commands which don't use
> >>> --children feature like 'perf script' or even 'perf report/top' without
> >>> --children are better to keep caller order.
> >
> > Oops, there's a typo: s/caller order/callee order/ :)
>
> Thanks, I was wondering about that (and I've made that typo myself).
> Thanks for the patch!

Brendan, can I take that as an Acked-by?

> Brendan


\
 
 \ /
  Last update: 2015-10-22 16:21    [W:0.092 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site