lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] clk: imx31: add missing of_node_put
    On 10/21, Julia Lawall wrote:
    > for_each_compatible_node performs an of_node_get on each iteration, so a
    > break out of the loop requires an of_node_put.
    >
    > The semantic patch that fixes this problem is as follows
    > (http://coccinelle.lip6.fr):
    >
    > // <smpl>
    > @@
    > local idexpression n;
    > expression e;
    > @@
    >
    > for_each_compatible_node(n,...) {
    > ...
    > (
    > of_node_put(n);
    > |
    > e = n
    > |
    > + of_node_put(n);
    > ? break;
    > )
    > ...
    > }
    > ... when != n
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > ---

    Applied to clk-next

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project


    \
     
     \ /
      Last update: 2015-10-22 01:41    [W:2.234 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site