lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 3/4] of: overlay: add per overlay sysfs attributes
From
Date
Hi Rob,

> On Oct 21, 2015, at 00:54 , Rob Herring <robherring2@gmail.com> wrote:
>
> On Tue, Oct 20, 2015 at 4:11 PM, Pantelis Antoniou
> <pantelis.antoniou@konsulko.com> wrote:
>> Hi Rob,
>>
>>> On Oct 21, 2015, at 00:04 , Rob Herring <robherring2@gmail.com> wrote:
>>>
>>> On Tue, Oct 20, 2015 at 2:13 PM, Pantelis Antoniou
>>> <pantelis.antoniou@konsulko.com> wrote:
>>>> * A per overlay can_remove sysfs attribute that reports whether
>>>> the overlay can be removed or not due to another overlapping overlay.
>>>>
>>>> * A target sysfs attribute listing the target of each fragment,
>>>> in a group named after the name of the fragment.
>
> [...]
>
>>>> @@ -255,6 +278,17 @@ err_fail:
>>>> return -EINVAL;
>>>> }
>>>>
>>>> +static ssize_t target_show(struct kobject *kobj,
>>>> + struct fragment_attribute *fattr, char *buf)
>>>> +{
>>>> + struct of_overlay_info *ovinfo = fattr->ovinfo;
>>>> +
>>>> + return snprintf(buf, PAGE_SIZE, "%s\n",
>>>> + of_node_full_name(ovinfo->target));
>>>
>>> This can be a link to the node itself, can't it?
>>>
>>
>> Yes. Do you want it like this?
>
> Yes, hence the suggestion. Unless you see some reason why not.
>

Nope, can’t be done. The sysfs API only allows linking one kobj to another.
The kobj is the overlay but the target is in the fragment attribute group.

Sorry, I really tried, but can’t be done without hacking in a new link sysfs API.

> Rob

Regards

— Pantelis



\
 
 \ /
  Last update: 2015-10-21 22:01    [W:0.093 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site