Messages in this thread Patch in this message | | | From | Punit Vara <> | Subject | [PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg | Date | Thu, 22 Oct 2015 00:37:08 +0530 |
| |
remove int ret suggested by Jiri Slaby This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck:
WARNING: end returns can be simplified if negative or 0 value
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/at76c50x-usb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c index dab2513..b4aa062 100644 --- a/drivers/net/wireless/at76c50x-usb.c +++ b/drivers/net/wireless/at76c50x-usb.c @@ -543,14 +543,10 @@ static void at76_ledtrig_tx_activity(void) static int at76_remap(struct usb_device *udev) { - int ret; - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, + return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, USB_TYPE_VENDOR | USB_DIR_OUT | USB_RECIP_INTERFACE, 0, 0, NULL, 0, USB_CTRL_GET_TIMEOUT); - if (ret < 0) - return ret; - return 0; } static int at76_get_op_mode(struct usb_device *udev) -- 2.5.3
| |