lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mm: memcontrol: eliminate root memory.current
    Date
    memory.current on the root level doesn't add anything that wouldn't be
    more accurate and detailed using system statistics. It already doesn't
    include slabs, and it'll be a pain to keep in sync when further memory
    types are accounted in the memory controller. Remove it.

    Note that this applies to the new unified hierarchy interface only.

    Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
    ---
    mm/memcontrol.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    Tejun, we should probably do this with the other controllers too.
    I don't think it makes sense anywhere to shoddily duplicate the
    system statistics on the controller root levels.

    diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    index 4f04510..c71fe40 100644
    --- a/mm/memcontrol.c
    +++ b/mm/memcontrol.c
    @@ -5022,7 +5022,7 @@ static void mem_cgroup_bind(struct cgroup_subsys_state *root_css)
    static u64 memory_current_read(struct cgroup_subsys_state *css,
    struct cftype *cft)
    {
    - return mem_cgroup_usage(mem_cgroup_from_css(css), false);
    + return page_counter_read(&mem_cgroup_from_css(css)->memory);
    }

    static int memory_low_show(struct seq_file *m, void *v)
    @@ -5134,6 +5134,7 @@ static int memory_events_show(struct seq_file *m, void *v)
    static struct cftype memory_files[] = {
    {
    .name = "current",
    + .flags = CFTYPE_NOT_ON_ROOT,
    .read_u64 = memory_current_read,
    },
    {
    --
    2.6.1


    \
     
     \ /
      Last update: 2015-10-21 21:21    [W:3.070 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site