lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper
From
Date
On 10/21/15 5:06 AM, Peter Zijlstra wrote:
>> PERF_COUNT_SW_DUMMY = 9,
>> >+ PERF_COUNT_SW_BPF_OUTPUT = 10,
>> >
>> > PERF_COUNT_SW_MAX, /* non-ABI */
>> > };
> Do you really need the new type? Can't you use DUMMY for this?

It works fine with dummy, but user space code looked odd when
it perf_event_open-s dummy events and starts reading them.
So I thought either to add alias:
PERF_COUNT_SW_BPF_OUTPUT = PERF_COUNT_SW_DUMMY
or
add new number like I did above.
New number is cheap and I saw that dummy used for probing,
so went with new number to disambiguate.



\
 
 \ /
  Last update: 2015-10-21 19:41    [W:0.201 / U:1.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site