Messages in this thread | | | Date | Wed, 21 Oct 2015 17:44:01 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH 1/3] staging: comedi: make ni_tio_has_gate2_registers return boolean |
| |
On 18/10/15 15:35, Geliang Tang wrote: > This patch makes ni_tio_has_gate2_registers return boolean, since > this function only uses either one or zero as its return value. > > Signed-off-by: Geliang Tang <geliangtang@163.com> > --- > drivers/staging/comedi/drivers/ni_tio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c > index c20c51b..b74e44e 100644 > --- a/drivers/staging/comedi/drivers/ni_tio.c > +++ b/drivers/staging/comedi/drivers/ni_tio.c > @@ -167,15 +167,15 @@ static inline unsigned GI_HW_ARM_SEL_MASK(enum ni_gpct_variant variant) > } > } > > -static int ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev) > +static bool ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev) > { > switch (counter_dev->variant) { > case ni_gpct_variant_e_series: > default: > - return 0; > + return false; > case ni_gpct_variant_m_series: > case ni_gpct_variant_660x: > - return 1; > + return true; > } > } > >
Looks okay!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |