lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2] fpga: zynq-fpga: Change fw format to handle bin instead of bit.
From
Date
On 10/20/2015 07:19 PM, Moritz Fischer wrote:
> This gets rid of the code to strip away the header and byteswap,
> as well as the check for the sync word.
>
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
> v2:
> - Removed early exit path in case synq seq is not found
> ---
> drivers/fpga/zynq-fpga.c | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 617d382..31db550 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -287,9 +287,9 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr,
> struct zynq_fpga_priv *priv;
> int err;
> char *kbuf;
> - size_t i, in_count;
> + size_t in_count;
> dma_addr_t dma_addr;
> - u32 transfer_length = 0;
> + u32 transfer_length;
> u32 intr_status;
>
> in_count = count;
> @@ -301,26 +301,6 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr,
>
> memcpy(kbuf, buf, count);
>
> - /* look for the sync word */
> - for (i = 0; i < count - 4; i++) {
> - if (memcmp(kbuf + i, "\xAA\x99\x55\x66", 4) == 0) {
> - dev_dbg(priv->dev, "Found swapped sync word\n");
> - break;
> - }
> - }
> -
> - /* remove the header, align the data on word boundary */
> - if (i != count - 4) {
> - count -= i;
> - memmove(kbuf, kbuf + i, count);
> - }
> -
> - /* fixup endianness of the data */
> - for (i = 0; i < count; i += 4) {
> - u32 *p = (u32 *)&kbuf[i];
> - *p = swab32(*p);
> - }
> -
> /* enable clock */
> err = clk_enable(priv->clk);
> if (err)
>

Looks good.
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal



\
 
 \ /
  Last update: 2015-10-21 09:01    [W:0.064 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site