lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same}
From
Date
On Wed, 2015-10-21 at 09:39 -0400, Jeff Moyer wrote:
> Christoph Hellwig <hch@infradead.org> writes:
>
> > Jens, Ming:
> >
> > are you fine with the one liner change to get back to the old I/O
> > pattern? While it looks like the cards fault I'd like to avoid this
> > annoying regression.
>
> I'm not Jens or Ming, but your patch looks fine to me, though you'll
> want to remove the MAX_BIO_SECTORS definition since it's now unused.
> It's not clear to me why the limit was lowered in the first place.

UINT_MAX >> 9 is not power of 2 and it causes dm-thinp discard fails.

At the lengthy discussion:
[PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
We agreed to cap discard to 2G as an interim solution for 4.3 until the
dm-thinp discard code is rewritten.

Hi Mike,

Will the dm-thinp discard rewritten ready for 4.4?

Thanks,
Ming

>
> You can add my Reviewed-by: Jeff Moyer <jmoyer@redhat.com> if you resend
> the patch.
>
> -Jeff




\
 
 \ /
  Last update: 2015-10-21 17:21    [W:0.070 / U:2.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site