lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks
    From
    Date
    On 10/21/2015, 04:55 PM, Punit Vara wrote:
    > This patch is to the ath10k/pci.h file that fixes following warning
    > reported by coccicheck:
    >
    > WARNING: sum of probable bitmasks, consider |
    >
    > I have replaced + with OR operator | for summing bitmasks
    >
    > Signed-off-by: Punit Vara <punitvara@gmail.com>
    > ---
    > drivers/net/wireless/ath/ath10k/pci.c | 10 +++++-----
    > 1 file changed, 5 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
    > index 1046ab6..165a318 100644
    > --- a/drivers/net/wireless/ath/ath10k/pci.c
    > +++ b/drivers/net/wireless/ath/ath10k/pci.c
    > @@ -775,7 +775,7 @@ static u32 ath10k_pci_targ_cpu_to_ce_addr(struct ath10k *ar, u32 addr)
    > switch (ar->hw_rev) {
    > case ATH10K_HW_QCA988X:
    > case ATH10K_HW_QCA6174:
    > - val = (ath10k_pci_read32(ar, SOC_CORE_BASE_ADDRESS +
    > + val = (ath10k_pci_read32(ar, SOC_CORE_BASE_ADDRESS |
    > CORE_CTRL_ADDRESS) &

    Could you explain where exactly are 2 bitmasks here?

    thanks,
    --
    js


    \
     
     \ /
      Last update: 2015-10-21 17:21    [W:7.254 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site