Messages in this thread Patch in this message | | | Subject | [PATCH 3/6] keys: Be more consistent in selection of union members used | From | David Howells <> | Date | Wed, 21 Oct 2015 15:27:06 +0100 |
| |
From: Insu Yun <wuninsu@gmail.com>
key->description and key->index_key.description are same because they are unioned. But, for readability, using same name for duplication and validation seems better.
Signed-off-by: Insu Yun <wuninsu@gmail.com> Signed-off-by: David Howells <dhowells@redhat.com> ---
security/keys/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/key.c b/security/keys/key.c index aee2ec5a18fc..c0478465d1ac 100644 --- a/security/keys/key.c +++ b/security/keys/key.c @@ -278,7 +278,7 @@ struct key *key_alloc(struct key_type *type, const char *desc, key->index_key.desc_len = desclen; key->index_key.description = kmemdup(desc, desclen + 1, GFP_KERNEL); - if (!key->description) + if (!key->index_key.description) goto no_memory_3; atomic_set(&key->usage, 1);
| |