lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator, dt: add dt support for tps6502x regulator
From
Date
Hello Mark,

Am 21.10.2015 um 14:19 schrieb Mark Brown:
> On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote:
>
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/tps65023.dtsi
>
> If this file is needed there is something broken, if this file is not
> needed then it is just noise since everything in it needs to be
> overridden by users anyway. Either way please remove it.

Uh, I thought to do it like:

arch/arm/boot/dts/tps65217.dtsi

but, okay, removed.

>> + vldo2_reg: regulator@4 {
>> + reg = <4>;
>> + regulator-compatible = "vldo2", "regulator-compatible";
>
> Modern bindings no longer use regulator-compatible, they just use the
> node name - please look at recently added bindings for examples.

removed.

Thanks for the review!

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


\
 
 \ /
  Last update: 2015-10-21 15:21    [W:2.561 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site