lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 126/156] perf hists: Update the column width for the "srcline" sort key
    Date
    3.19.8-ckt8 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    commit e8e6d37e73e6b950c891c780745460b87f4755b6 upstream.

    When we introduce a new sort key, we need to update the
    hists__calc_col_len() function accordingly, otherwise the width
    will be limited to strlen(header).

    We can't update it when obtaining a line value for a column (for
    instance, in sort__srcline_cmp()), because we reset it all when doing a
    resort (see hists__output_recalc_col_len()), so we need to, from what is
    in the hist_entry fields, set each of the column widths.

    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Fixes: 409a8be61560 ("perf tools: Add sort by src line/number")
    Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    tools/perf/util/hist.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
    index 1823955..db18023 100644
    --- a/tools/perf/util/hist.c
    +++ b/tools/perf/util/hist.c
    @@ -151,6 +151,9 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
    hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);
    hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);

    + if (h->srcline)
    + hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline));
    +
    if (h->transaction)
    hists__new_col_len(hists, HISTC_TRANSACTION,
    hist_entry__transaction_len());
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-10-21 00:01    [W:4.230 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site