Messages in this thread | | | Date | Tue, 20 Oct 2015 21:24:24 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal |
| |
On Tue, 20 Oct 2015, Russell King - ARM Linux wrote:
> On Tue, Oct 20, 2015 at 04:08:28PM +0200, Thomas Petazzoni wrote: > > As discussed on IRC, another simpler (code line wise) solution is to > > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which > > brings us back to what set_irq_flags() was doing, without actually > > reverting Rob's patch. > > > > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the > > right long term solution, which is why I implemented what I believe is > > a (hopefully) better long term solution. > > However, this is rather worrying. NOAUTOEN is supposed to avoid enabling > the interrupt when the interrupt is claimed. > > If, as a result of Rob's patch, we now have a load of IRQs which are > marked with NOAUTOEN which weren't, that's quite a large regression - > possibly one which hasn't been properly found (not everyone tests -rc > kernels) and we may be better to revert Rob's patch to avoid lots of > breakge being reported when 4.3 is released. > > I think Rob's patches need another review in light of this, to determine > how much breakage there is here, and a decision how to proceed made on > that basis.
I'll go over them tomorrow again and decide then what to do.
Thanks,
tglx
| |