lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/4] KVM: use simple waitqueue for vcpu->wq
From
Date


On 20/10/2015 16:00, Peter Zijlstra wrote:
>> > - prepare_to_wait(&vcpu->wq, &wait, TASK_INTERRUPTIBLE);
>> > + prepare_to_swait(&vcpu->wq, &wait, TASK_INTERRUPTIBLE);
>> >
>> > if (kvm_vcpu_check_block(vcpu) < 0)
>> > break;
>> > @@ -2028,7 +2027,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>> > schedule();
>> > }
>> >
>> > - finish_wait(&vcpu->wq, &wait);
>> > + finish_swait(&vcpu->wq, &wait);
>> > cur = ktime_get();
>> >
>> > out:
> Should we not take this opportunity to get rid of these open-coded wait
> loops?

I find them way more readable than a 6-argument __wait_event...

I've forwarded your remark about kvmppc_vcore_blocked to the kvm-ppc
maintainers.

Thanks,

Paolo


\
 
 \ /
  Last update: 2015-10-20 18:01    [W:0.166 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site