Messages in this thread | | | Date | Tue, 20 Oct 2015 08:03:30 -0000 | Subject | Re: [PATCH v2 0/8] Fix error message and present UFS variant | From | ygardi@codeauro ... |
| |
> Hi Yaniv, > > 2015-08-23 22:09 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>: >> V3: fixes a few minor issues. >> >> V2: fixes a few issues of unnecessary EXPORT_SYMBOL, >> types of parameters in routine definition, >> build errors in case CONFIG_PM is not defined and some >> other minor fixes. > > I've checked outstanding issues I reported for v1 and v2 are fixed > in this version of series. So please feel free to add: > > Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com> > > I still think that we should introduce print_hex_dump_io() or > something simpler for dumping __iomem pointer instead of casting > 'void __force *'. But it is only used for debug dump function, so > I don't too much worry about it. >
Thanks, Mita, as you say, since this is mainly for debug dump functions, so i agree that for now, we may keep it as is.
Yaniv
| |