lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 02/60] sparc/PCI: Use correct bus address to resource offset
From
On Tue, Oct 20, 2015 at 4:51 PM, Khalid Aziz <khalid.aziz@oracle.com> wrote:
> On 10/20/2015 02:34 PM, Yinghai Lu wrote:
>>
>> On Tue, Oct 20, 2015 at 1:07 PM, Khalid Aziz <khalid.aziz@oracle.com>
>> wrote:
>>>>
>>>> I don't want to argue about pci_resource_to_user() right now, so I
>>>> guess you can just panic if the mem64 offset is different from the
>>>> mem32 offset. But you should at least add a comment about why you're
>>>> doing that. Otherwise it looks like you were just lazy.
>>
>>
>> I had one version for that, but it has big change to
>> __pci_mmap_make_offset_bus
>> for making pci_mmap_resource() working.
>> And took it for granted that MEM/MEM64 should have same offet.
>>
>>>
>>>
>>> I just hit this condition on a sparc platform where mem32 offset != mem64
>>> offset. We need to handle this case, and not just call panic. I had not
>>> seen
>>> this on 5 platforms and another 3 ldoms I had tested this on when I
>>> tested
>>> this code earlier. I have sent panic log to Yinghai separately.
>>
>>
>> Did you get test result with updated patch2 and patch3?
>>
>
> Hi Yinghai,
>
> The failing T4 booted up with updated patches.
>

Thanks, will post updated patch2 and patches3 and patch 4 with
pcibios_bus_to_resource as Bjorn requested.

Yinghai


\
 
 \ /
  Last update: 2015-10-21 02:21    [W:0.088 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site