lkml.org 
[lkml]   [2015]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: vmpressure: fix scan window after SWAP_CLUSTER_MAX increase
    On Mon, Oct 19, 2015 at 02:13:01PM -0400, Johannes Weiner wrote:
    > mm-increase-swap_cluster_max-to-batch-tlb-flushes.patch changed
    > SWAP_CLUSTER_MAX from 32 pages to 256 pages, inadvertantly switching
    > the scan window for vmpressure detection from 2MB to 16MB. Revert.
    >
    > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

    This was known at the time but it was not clear what the measurable
    impact would be. VM Pressure is odd in that it gives strange results at
    times anyway, particularly on NUMA machines. To be honest, it still isn't
    clear to me what the impact of the patch is. With different base page sizes
    (e.g. on ppc64 with some configs), the window is still large. At the time,
    it was left as-is as I could not decide one way or the other but I'm ok
    with restoring the behaviour so either way;

    Acked-by: Mel Gorman <mgorman@techsingularity.net>

    Out of curiosity though, what *is* the user-visible impact of the patch
    though? It's different but I'm having trouble deciding if it's better
    or worse. I'm curious as to whether the patch is based on a bug report
    or intuition.

    Thanks.

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2015-10-20 10:21    [W:3.638 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site