lkml.org 
[lkml]   [2015]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/5] PCI: Add support for PCI Enhanced Allocation "BARs"
Hi David,

I did a quick look through & overall I what you have done.
I will try to find some time to do a full review early next week.

Thanks Again,
Sean

On Fri, Oct 02, 2015 at 03:37:51PM -0700, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> The original patches are from Sean O. Stalley. I made a few tweaks,
> but feel that it is substancially Sean's work, so I am keeping the
> patch set version numbering scheme going.
>
> Tested on Cavium ThunderX system with 4 Root Complexes containing 50
> devices/bridges provisioned with EA.
>
> Here is Sean's description of the patches:
>
> PCI Enhanced Allocation is a new method of allocating MMIO & IO
> resources for PCI devices & bridges. It can be used instead
> of the traditional PCI method of using BARs.
>
> EA entries are hardware-initialized to a fixed address.
> Unlike BARs, regions described by EA are cannot be moved.
> Because of this, only devices which are permanently connected to
> the PCI bus can use EA. A removable PCI card must not use EA.
>
> This patchset adds support for using EA entries instead of BARs
> on Root Complex Integrated Endpoints.
>
> The Enhanced Allocation ECN is publicly available here:
> https://www.pcisig.com/specifications/conventional/ECN_Enhanced_Allocation_23_Oct_2014_Final.pdf
>
>
> Changes from V1:
> - Use generic PCI resource claim functions (instead of EA-specific functions)
> - Only add support for RCiEPs (instead of all devices).
> - Removed some debugging messages leftover from early testing.
>
> Changes from V2 (By David Daney):
> - Add ea_cap to struct pci_device, to aid in finding the EA capability.
> - Factored EA entity decoding into a separate function.
> - Add functions to find EA entities by BEI or Property.
> - Add handling of EA provisioned bridges.
> - Add handling of EA SRIOV BARs.
> - Try to assign proper resource parent so that SRIOV device creation can occur.
>
> Changes from V3 (By David Daney):
> - Discarded V3 changes and started over fresh based on Sean's V2.
> - Add more support/checking for Entry Properties.
> - Allow EA behind bridges.
> - Rewrite some error messages.
> - Add patch 3/5 to prevent resizing, and better handle
> assigning, of fixed EA resources.
> - Add patch 4/5 to handle EA provisioned SRIOV devices.
> - Add patch 5/5 to handle EA provisioned bridges.
>
> David Daney (3):
> PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.
> PCI: Handle Enhanced Allocation (EA) capability for SRIOV devices.
> PCI: Handle Enhanced Allocation (EA) capability for bridges
>
> Sean O. Stalley (2):
> PCI: Add Enhanced Allocation register entries
> PCI: Add support for Enhanced Allocation devices
>
> drivers/pci/bus.c | 7 ++
> drivers/pci/iov.c | 11 ++-
> drivers/pci/pci.c | 202 ++++++++++++++++++++++++++++++++++++++++++
> drivers/pci/pci.h | 1 +
> drivers/pci/probe.c | 34 ++++++-
> drivers/pci/setup-bus.c | 63 ++++++++++++-
> include/linux/pci.h | 1 +
> include/uapi/linux/pci_regs.h | 44 ++++++++-
> 8 files changed, 355 insertions(+), 8 deletions(-)
>
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-10-03 02:01    [W:0.343 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site