lkml.org 
[lkml]   [2015]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 5/5] PCI: generic: Pass proper starting bus number to pci_scan_root_bus().
    Date
    From: David Daney <david.daney@cavium.com>

    If the bus is being configured with a bus-range that does not start at
    zero, pass that starting bus number to pci_scan_root_bus(). Passing
    the incorrect value of zero causes attempted config accesses outside
    of the supported range, which cascades to an OOPs spew and eventual
    kernel panic.

    Acked-by: Will Deacon <will.deacon@arm.com>
    Signed-off-by: David Daney <david.daney@cavium.com>
    ---
    No change from v3.

    drivers/pci/host/pci-host-generic.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
    index 5cce837..eb4b7c7 100644
    --- a/drivers/pci/host/pci-host-generic.c
    +++ b/drivers/pci/host/pci-host-generic.c
    @@ -264,7 +264,8 @@ static int gen_pci_probe(struct platform_device *pdev)
    if (!pci_has_flag(PCI_PROBE_ONLY))
    pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);

    - bus = pci_scan_root_bus(dev, 0,
    +
    + bus = pci_scan_root_bus(dev, pci->cfg.bus_range->start,
    &pci->cfg.ops->ops, pci, &pci->resources);
    if (!bus) {
    dev_err(dev, "Scanning rootbus failed");
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-10-02 21:01    [W:2.155 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site