lkml.org 
[lkml]   [2015]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Input: db9 - store object at correct index
Hi Sudip,

On Fri, Oct 02, 2015 at 04:58:33PM +0530, Sudip Mukherjee wrote:
> The variable i is used to check the port to attach to and we are
> supposed to save the reference of struct db9 in the location given by
> db9_base[i]. But after finding out the index i is getting modified again
> so we saved in a wrong index.
>
> Fixes: 2260c419b52b ("Input: db9 - use parallel port device model")
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/input/joystick/db9.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c
> index cf1f602..f6ecd4a 100644
> --- a/drivers/input/joystick/db9.c
> +++ b/drivers/input/joystick/db9.c
> @@ -560,7 +560,7 @@ static void db9_attach(struct parport *pp)
> const struct db9_mode_data *db9_mode;
> struct pardevice *pd;
> struct input_dev *input_dev;
> - int i, j;
> + int i, j, k;
> int mode;
> struct pardev_cb db9_parport_cb;
>
> @@ -577,6 +577,7 @@ static void db9_attach(struct parport *pp)
> pr_debug("Not using parport%d.\n", pp->number);
> return;
> }
> + k = i;

Hmm, I'd prefer we did not reuse 'i' at all. Can we instead of 'k' add
'port_idx' and use it instead of 'i' in the first loop?

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2015-10-02 20:21    [W:0.968 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site