Messages in this thread | | | Subject | Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations | From | Felix Fietkau <> | Date | Fri, 2 Oct 2015 15:25:09 +0200 |
| |
On 2015-10-02 12:48, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Tested-by: Andrew Lunn <andrew@lunn.ch> > Tested-by: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> I think you also need to get rid of the corresponding free calls in the error path, otherwise it will probably crash at some point.
- Felix
| |