| Subject | Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag | | From | Sudeep Holla <> | | Date | Fri, 2 Oct 2015 11:45:18 +0100 |
| |
On 02/10/15 11:40, Linus Walleij wrote: > On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > >> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >> be left enabled so as to allow them to work as expected during the >> suspend-resume cycle, but doesn't guarantee that it will wake the system >> from a suspended state, enable_irq_wake is recommended to be used for >> the wakeup. >> >> This patch removes the use of IRQF_NO_SUSPEND flags and uses newly >> introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Alessandro Zummo <a.zummo@towertech.it> >> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> >> Cc: rtc-linux@googlegroups.com >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > Looks correct to me. > Acked-by: Linus Walleij <linus.walleij@linaro.org> >
Thanks, while you are at it, do you know what interrupt stv2_pl031 shares so that I can fix the TODO in the comment or the code(whichever applicable).
Regards, Sudeep
|