lkml.org 
[lkml]   [2015]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling
于 2015/10/20 10:14, Alexei Starovoitov 写道:
> On 10/19/15 3:37 AM, Kaixu Xia wrote:
>> +/* flags for PERF_EVENT_ARRAY maps*/
>> +enum {
>> + BPF_EVENT_CTL_BIT_CUR = 0,
>> + BPF_EVENT_CTL_BIT_ALL = 1,
>> + __NR_BPF_EVENT_CTL_BITS,
>> +};
>> +
>> +#define BPF_CTL_BIT_FLAG_MASK \
>> + ((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1)
>> +#define BPF_CTL_BIT_DUMP_CUR \
>> + (1ULL << BPF_EVENT_CTL_BIT_CUR)
>> +#define BPF_CTL_BIT_DUMP_ALL \
>> + (1ULL << BPF_EVENT_CTL_BIT_ALL)
>> +
>
> the above shouldn't be part of uapi header. It can stay in bpf_trace.c
> Just document these bits next to helper similar to skb_store_bytes()
>
> The rest looks ok.
> It still needs an ack from Peter for perf_event bits

Thanks for your comments!
This part will be moved to bpf_trace.c in next version.
>
>
> .
>




\
 
 \ /
  Last update: 2015-10-20 05:01    [W:0.042 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site