lkml.org 
[lkml]   [2015]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 24/79] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Tan, Jui Nee" <jui.nee.tan@intel.com>

    commit 02bc933ebb59208f42c2e6305b2c17fd306f695d upstream.

    On Intel Baytrail, there is case when interrupt handler get called, no SPI
    message is captured. The RX FIFO is indeed empty when RX timeout pending
    interrupt (SSSR_TINT) happens.

    Use the BIOS version where both HSUART and SPI are on the same IRQ. Both
    drivers are using IRQF_SHARED when calling the request_irq function. When
    running two separate and independent SPI and HSUART application that
    generate data traffic on both components, user will see messages like
    below on the console:

    pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler

    This commit will fix this by first checking Receiver Time-out Interrupt,
    if it is disabled, ignore the request and return without servicing.

    Signed-off-by: Tan, Jui Nee <jui.nee.tan@intel.com>
    Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-pxa2xx.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/spi/spi-pxa2xx.c
    +++ b/drivers/spi/spi-pxa2xx.c
    @@ -562,6 +562,10 @@ static irqreturn_t ssp_int(int irq, void
    if (!(sccr1_reg & SSCR1_TIE))
    mask &= ~SSSR_TFS;

    + /* Ignore RX timeout interrupt if it is disabled */
    + if (!(sccr1_reg & SSCR1_TINTE))
    + mask &= ~SSSR_TINT;
    +
    if (!(status & mask))
    return IRQ_NONE;




    \
     
     \ /
      Last update: 2015-10-18 06:01    [W:2.718 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site