lkml.org 
[lkml]   [2015]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section
From
Date
On 10/16/2015 08:44 AM, Sebastian Reichel wrote:
> The IRQ handler is not used by the platform based
> code resulting in a 'defined but not used' warning,
> if CONFIG_BQ27XXX_I2C is not enabled.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> drivers/power/bq27xxx_battery.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 69e6b371a51c..880233ce9343 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -762,15 +762,6 @@ static void bq27xxx_battery_update(struct bq27xxx_device_info *di)
> di->last_update = jiffies;
> }
>
> -static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
> -{
> - struct bq27xxx_device_info *di = data;
> -
> - bq27xxx_battery_update(di);
> -
> - return IRQ_HANDLED;
> -}
> -
> static void bq27xxx_battery_poll(struct work_struct *work)
> {
> struct bq27xxx_device_info *di =
> @@ -1061,6 +1052,15 @@ static void bq27xxx_powersupply_unregister(struct bq27xxx_device_info *di)
> static DEFINE_IDR(battery_id);
> static DEFINE_MUTEX(battery_mutex);
>
> +static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data)
> +{
> + struct bq27xxx_device_info *di = data;
> +
> + bq27xxx_battery_update(di);
> +
> + return IRQ_HANDLED;
> +}
> +
> static int bq27xxx_battery_i2c_read(struct bq27xxx_device_info *di, u8 reg,
> bool single)
> {
>

Acked-by: Andrew F. Davis <afd@ti.com>

--
Andrew F. Davis


\
 
 \ /
  Last update: 2015-10-16 17:21    [W:0.307 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site