Messages in this thread | | | From | "Franklin S Cooper Jr." <> | Subject | Re: [PATCH] spi: Setup the master controller driver before setting the chipselect | Date | Fri, 16 Oct 2015 09:45:48 -0500 |
| |
On 10/16/2015 09:43 AM, Mark Brown wrote: > On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > >> Makes sense. How about something like this? >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a chance >> to perform their setup procedure before trying to use the chip >> select. > Yes, that's a lot better - there's also the fact that if we assert chip > select before we've got the pins in a good state we may cause the device > to see signals that confuse it as we change. Ok. I'll submit a rev2 with my updated commit message and incorporate your suggestion also.
| |