Messages in this thread | | | Date | Fri, 16 Oct 2015 17:06:18 +0800 | From | Huang Rui <> | Subject | Re: [PATCH] input: i8042: add quirk to implement i8042 detect for AMD |
| |
On Fri, Oct 16, 2015 at 04:58:09PM +0800, Borislav Petkov wrote: > On Fri, Oct 16, 2015 at 09:27:00AM -0400, Vincent Wan wrote: > > Detecting platform supports i8042 or not, AMD resorted to > > BIOS's FADT i8042 flag. > > > > Signed-off-by: Vincent Wan <Vincent.Wan@amd.com> > > --- > > drivers/input/serio/i8042-x86ia64io.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h > > index c115565..bf3a605 100644 > > --- a/drivers/input/serio/i8042-x86ia64io.h > > +++ b/drivers/input/serio/i8042-x86ia64io.h > > @@ -9,6 +9,7 @@ > > > > #ifdef CONFIG_X86 > > #include <asm/x86_init.h> > > +#include <linux/acpi.h> > > #endif > > > > /* > > @@ -1047,6 +1048,11 @@ static int __init i8042_platform_init(void) > > /* Just return if pre-detection shows no i8042 controller exist */ > > if (!x86_platform.i8042_detect()) > > return -ENODEV; > > + > > + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) { > > Why the vendor check if you're accessing a bit defined in the ACPI spec? >
Yeah, I have the same concern with AMD vendor check. :)
Aaron, could you please help to check the impact at intel platfomrs if we remove this check?
Thanks, Rui
| |