lkml.org 
[lkml]   [2015]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default methods
Bjorn,

On Thu, 15 Oct 2015, Thomas Gleixner wrote:
> On Tue, 13 Oct 2015, Marc Zyngier wrote:
>
> > When we create a generic MSI domain, that MSI_FLAG_USE_DEF_CHIP_OPS
> > is set, and that any of .mask or .unmask are NULL in the irq_chip
> > structure, we set them to pci_msi_[un]mask_irq.
> >
> > This is a bad idea for at least two reasons:
> > - PCI_MSI might not be selected, kernel fails to build (yes, this is
> > legitimate, at least on arm64!)
> > - This may not be a PCI/MSI domain at all (platform MSI, for example)
> >
> > Either way, this looks wrong. Move the overriding of mask/unmask to
> > the PCI counterpart, and panic is any of these two methods is not
> > set in the core code (they really should be present).
> >
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Should I take that one?

Thanks,

tglx


\
 
 \ /
  Last update: 2015-10-16 12:01    [W:0.052 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site