lkml.org 
[lkml]   [2015]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] PCI: iproc: fix 32-bit build error
    Date
    On Thursday 15 October 2015 16:01:13 Bjorn Helgaas wrote:
    > On Thu, Oct 15, 2015 at 09:40:45PM +0200, Arnd Bergmann wrote:
    > > The iproc PCI driver tries to figure out whether the MMIO window has
    > > a valid size, but does this using a 64-bit modulo operation, which
    > > is not allowed on 32-bit kernels and leads to a link error:
    > >
    > > drivers/built-in.o: In function `iproc_pcie_setup':
    > > :(.text+0x4b798): undefined reference to `__aeabi_uldivmod'
    > >
    > > This works around that error by using the div64_u64() function
    > > provided by the kernel. While this is an expensive operation,
    > > it is harmless because we only call it during the probing
    > > of the driver.
    > >
    > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > > Acked-by: Ray Jui <rjui@broadcom.com>
    > > Fixes: 0ab99ca8eb6c ("PCI: iproc: Fix compile warnings")
    >
    > This *looks* like it should be fixing 90e4032eeaf2 ("PCI: iproc: Add
    > outbound mapping support"), not 0ab99ca8eb6c.
    >
    > 90e4032eeaf2 added the "if (size % ob->window_size)".
    >
    > Is this more subtle than that?
    >
    >

    You are absolutely right, I must have copy-pasted the wrong entry.
    Do you want me to resend this? I guess you can just remove the
    line as this commit has not appeared in any release anyway.

    Arnd


    \
     
     \ /
      Last update: 2015-10-16 12:01    [W:3.960 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site