lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 23/79] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h
On (10/16/15 01:00), Mikko Rapeli wrote:
>
> What kind of portability should exported userspace headers from Linux kernel
> need?
>
> Reviews to my previous changes NACKed <stdint.h> usage and
> Documentation/CodingStyle chapter 5 says:
>
> (e) Types safe for use in userspace.
>
> In certain structures which are visible to userspace, we cannot
> require C99 types and cannot use the 'u32' form above. Thus, we
> use __u32 and similar types in all structures which are shared
> with userspace.

Let's be clear: we are not talking about u32 vs __u32, we are talking
about uint32_t vs __u32 in your patch.

I dont have the context of your "previous changes NACKed.." etc.
Why can we not require C99 types in rds.h?

Why isnt that a problem for, say, <netinet/in.h> which includes
<stdint.h>?

--Sowmini


\
 
 \ /
  Last update: 2015-10-16 00:41    [W:0.276 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site