lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fs/block_dev.c: Remove WARN_ON() when inode writeback fails
Date
Vivek Goyal <vgoyal@redhat.com> writes:

> Hi Jens,
>
> Do you have concerns with this patch? If not, can you please include it.

The concept is fine, but:

>> -static void bdev_write_inode(struct inode *inode)
>> +static void bdev_write_inode(struct block_device *bdev)
>> {
>> + struct inode *inode = bdev->bd_inode;
>> + int ret;
>> +
>> spin_lock(&inode->i_lock);
>> while (inode->i_state & I_DIRTY) {
>> spin_unlock(&inode->i_lock);
>> - WARN_ON_ONCE(write_inode_now(inode, true));
>> + ret = write_inode_now(inode, true);
>> + if (ret) {
>> + char name[BDEVNAME_SIZE] = "";

that initializer isn't necessary.

Cheers,
Jeff


\
 
 \ /
  Last update: 2015-10-15 18:41    [W:0.054 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site