Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH] fs/block_dev.c: Remove WARN_ON() when inode writeback fails | Date | Thu, 15 Oct 2015 12:23:06 -0400 |
| |
Vivek Goyal <vgoyal@redhat.com> writes:
> Hi Jens, > > Do you have concerns with this patch? If not, can you please include it.
The concept is fine, but:
>> -static void bdev_write_inode(struct inode *inode) >> +static void bdev_write_inode(struct block_device *bdev) >> { >> + struct inode *inode = bdev->bd_inode; >> + int ret; >> + >> spin_lock(&inode->i_lock); >> while (inode->i_state & I_DIRTY) { >> spin_unlock(&inode->i_lock); >> - WARN_ON_ONCE(write_inode_now(inode, true)); >> + ret = write_inode_now(inode, true); >> + if (ret) { >> + char name[BDEVNAME_SIZE] = "";
that initializer isn't necessary.
Cheers, Jeff
| |