lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace
Date
On Thursday 15 October 2015 20:12:35 Li Bin wrote:
>
> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +static void print_ftrace_graph_addr(unsigned long addr,
> + struct task_struct *tsk,
> + unsigned long sp, int *graph)
> +{
> + unsigned long ret_addr;
> + int index = tsk->curr_ret_stack;
> +
> + if (addr != ((unsigned long)return_to_handler - 4))
> + return;
> +
> + if (!tsk->ret_stack || index < *graph)
>

I think it would be nicer to remove the #ifdef and write this as

static void print_ftrace_graph_addr(unsigned long addr,
struct task_struct *tsk,
unsigned long sp, int *graph)
{
unsigned long ret_addr;
int index = tsk->curr_ret_stack;

if (!IS_ENABLED(CONFIG_FUNCTION_GRAPH_TRACER))
return;

if (addr != ((unsigned long)return_to_handler - 4))
return;



\
 
 \ /
  Last update: 2015-10-15 15:01    [W:0.069 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site