Messages in this thread | | | Date | Thu, 15 Oct 2015 12:03:34 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval |
| |
On Thu, Oct 15, 2015 at 05:18:26PM +0800, Dave Young wrote: > Seems there's no checking for other callback to memblock_reserve in setup.c > Need another cleanup?
True story. It sure does.
> BTW, a further cleanup is reasonable to me, there's a lot of below patter: > memblock_find_in_range > error checking > memblock_reserve > error checking > > So a new function memblock_reserve_in_range is reasonable.
Well, in some of the callsites, the first "error checking" issues a specific message, depending on the subsystem. The following memblock_reserve() is mostly unchecked though. At least that should be fixed...
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |