lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval
On Thu, Oct 15, 2015 at 05:18:26PM +0800, Dave Young wrote:
> Seems there's no checking for other callback to memblock_reserve in setup.c
> Need another cleanup?

True story. It sure does.

> BTW, a further cleanup is reasonable to me, there's a lot of below patter:
> memblock_find_in_range
> error checking
> memblock_reserve
> error checking
>
> So a new function memblock_reserve_in_range is reasonable.

Well, in some of the callsites, the first "error checking" issues
a specific message, depending on the subsystem. The following
memblock_reserve() is mostly unchecked though. At least that should be
fixed...

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.


\
 
 \ /
  Last update: 2015-10-15 12:21    [W:0.142 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site