lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: nvec: fixed few coding style warnings
On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote:
> > > - if (unlikely(nvec->rx == NULL)) {
> > > + if (!unlikely(nvec->rx)) {
> >
> > This isn't right. You intented to say:
> >
> > if (unlikely(!nvec->rx)) {
> >
> > But even better to just remove the unlikely entirely.
> >
> > if (!nvec->rx) {
>
> why? the "unlikely" is there to optimize a critical interrupt path.

The rule is that drivers should not use likely/unlikely() unless there
is a difference in benchmark numbers. How critical can it be when it's
always followed by a udelay(100)???

There are more important optimizations needed here.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-10-15 11:21    [W:0.053 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site