Messages in this thread Patch in this message | | | From | Amanieu d'Antras <> | Subject | [PATCH 20/20] signal: Remove unnecessary zero-initialization of siginfo_t | Date | Wed, 14 Oct 2015 21:59:31 +0100 |
| |
This is no longer required since copy_siginfo_from_user32 now initializes all siginfo_t fields properly.
Signed-off-by: Amanieu d'Antras <amanieu@gmail.com> --- kernel/ptrace.c | 1 - kernel/signal.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 787320d..3aa383b 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -1147,7 +1147,6 @@ int compat_ptrace_request(struct task_struct *child, compat_long_t request, break; case PTRACE_SETSIGINFO: - memset(&siginfo, 0, sizeof siginfo); if (copy_siginfo_from_user32( &siginfo, (struct compat_siginfo __user *) datap)) ret = -EFAULT; diff --git a/kernel/signal.c b/kernel/signal.c index 873e8e2..ce992f2 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -3022,7 +3022,7 @@ COMPAT_SYSCALL_DEFINE3(rt_sigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info; int ret = copy_siginfo_from_user32(&info, uinfo); if (unlikely(ret)) return ret; @@ -3066,7 +3066,7 @@ COMPAT_SYSCALL_DEFINE4(rt_tgsigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info; if (copy_siginfo_from_user32(&info, uinfo)) return -EFAULT; -- 2.6.1
| |