lkml.org 
[lkml]   [2015]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: nvec: fixed few coding style warnings
On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote:
> Fixed allignmnet issues and block comments usage
>

Split it apart by type of fix.

> @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> } else {
> nvec->rx = nvec_msg_alloc(nvec, NVEC_MSG_RX);
> /* Should not happen in a normal world */
> - if (unlikely(nvec->rx == NULL)) {
> + if (!unlikely(nvec->rx)) {

This isn't right. You intented to say:

if (unlikely(!nvec->rx)) {

But even better to just remove the unlikely entirely.

if (!nvec->rx) {

> nvec->state = 0;
> break;
> }

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-10-14 20:41    [W:0.104 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site