Messages in this thread | | | Date | Wed, 14 Oct 2015 21:05:41 +0300 | From | Dan Carpenter <> | Subject | Re: [patch 2/2] misc: mic/scif: fix wrap around tests |
| |
On Tue, Oct 13, 2015 at 08:21:24PM -0700, Sudeep Dutt wrote:
> > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t len, off_t offset, > > if ((map_flags & SCIF_MAP_FIXED) && > > ((ALIGN(offset, PAGE_SIZE) != offset) || > > (offset < 0) || > > - (offset + (off_t)len < offset))) > > + (len < LONG_MAX - offset))) > > Hi Dan, > Should this be > instead of < like the others?
Gar. You're right, obviously. Thanks. I will resend tomorrow.
regards, dan carpenter
| |