lkml.org 
[lkml]   [2015]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] iio: mma8452: support either of the available interrupt pins
On 10/14/2015 03:15 PM, Martin Kepplinger wrote:
[...]
> + if (irq1 > 0)
> + client->irq = irq1;

You must not overwrite client->irq, that field is manged by the I2C core and
is supposed to be read only for device drivers.

> + dev_info(&client->dev, "using interrupt line INT1\n");

This should probably be a dev_dbg()

> + } else {
> + client->irq = irq2;
> + dev_info(&client->dev, "using interrupt line INT2\n");

Same here

> + }


\
 
 \ /
  Last update: 2015-10-14 17:41    [W:0.050 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site