lkml.org 
[lkml]   [2015]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section
From
Date


There's one last little wrinkle .. In the current setup the defconfig
CONFIG_CMDLINE="" is used as a default in case the device tree has
nothing in it. In my changes, there is no identical functionality. The
only similar thing I have is the the CONFIG_CMDLINE_APPEND="" . The main
difference is that in the current implementation CONFIG_CMDLINE=""
doesn't get added at all if there is a device tree bootargs, but with my
implementation this line would be added unconditionally. It would
represent a subtle change where people would have to add into the DT
bootargs something to override what might be in the default command line.

For example,

if a config has CONFIG_CMDLINE_APPEND="debug" then they would have to
add a "loglevel=7" into the DT bootargs to get back to normal. I
wouldn't think people would want "debug" as the default, but oddly
enough some of the configs do have this. Some of them also have default
ip address setting, nfsroot= settings, and loglevel= settings.

What are your thoughts on this ? I think using the append type default
makes more sense because it's actually setting up global defaults. The
current complete replacement scheme seems to set the stage for people to
make an entirely custom default for a single development machine, which
IMO doesn't make sense. However, I'm not sure what the intent is with
the current setup.

Daniel


\
 
 \ /
  Last update: 2015-10-14 17:01    [W:0.121 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site