Messages in this thread | | | Subject | Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default | From | Roger Quadros <> | Date | Wed, 14 Oct 2015 14:54:53 +0300 |
| |
On 14/10/15 14:37, Sebastian Reichel wrote: > Hi, > > On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote: >> On 14/10/15 14:19, Sebastian Reichel wrote: >>> On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote: >>>> Let's keep the SSI ports disabled in the omap3.dtsi to avoid >>>> getting the following noise on the console for boards that don't >>>> use the SSI ports. >>>> >>>> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" >>>> >>>> As omap3-n900 uses one SSI port, mark it enabled there. >> >> Would it be preferable to disable the ssi-controller node as well in the >> omap3.dtsi file? > > If I remember it correctly, existing, but unused IP-Cores > should not be disabled in DT, so that hwmod picks them up > for power management.
OK. > > Note, that it actually is disabled in omap3.dtsi and then enabled in > omap34xx/omap36xx dts files (the other variants do not have an ssi > module).
Thanks for the info :)
cheers, -roger
[unhandled content-type:application/pgp-signature] | |