Messages in this thread Patch in this message | | | Date | Tue, 13 Oct 2015 17:58:54 -0000 | From | Thomas Gleixner <> | Subject | [patch 1/3] irqchip/mxs: Panic if ioremap or domain creation fails |
| |
From: Oleksij Rempel <linux@rempel-privat.de>
Current code will only warn and then dereference the NULL pointer or continue, which results in a fatal NULL pointer dereference later.
If the initialization fails, the machine is unusable, so panic right away.
[ tglx: Massaged changelog and picked the irqdomain panic from the next patch]
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> Cc: marc.zyngier@arm.com Cc: jason@lakedaemon.net Link: http://lkml.kernel.org/r/1444677334-12242-2-git-send-email-linux@rempel-privat.de Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- drivers/irqchip/irq-mxs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Index: tip/drivers/irqchip/irq-mxs.c =================================================================== --- tip.orig/drivers/irqchip/irq-mxs.c +++ tip/drivers/irqchip/irq-mxs.c @@ -97,7 +97,8 @@ static int __init icoll_of_init(struct d struct device_node *interrupt_parent) { icoll_base = of_iomap(np, 0); - WARN_ON(!icoll_base); + if (!icoll_base) + panic("%s: unable to map resource", np->full_name); /* * Interrupt Collector reset, which initializes the priority @@ -107,6 +108,9 @@ static int __init icoll_of_init(struct d icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS, &icoll_irq_domain_ops, NULL); - return icoll_domain ? 0 : -ENODEV; + if (!icoll_domain) + panic("%s: unable to create irqdomain", np->full_name); + + return 0; } IRQCHIP_DECLARE(mxs, "fsl,icoll", icoll_of_init);
| |