Messages in this thread | | | Date | Tue, 13 Oct 2015 12:51:17 +0200 | From | Rabin Vincent <> | Subject | Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind |
| |
On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote: > On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa <jolsa@redhat.com> wrote: > > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote: > >> Even if --symfs is used to point to the debug binaries, we send in the > >> non-debug filenames to libunwind, which leads to libunwind not finding > >> the debug frame. Fix this. > >> > >> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com> > > > > cc-ing Namhyung on this one > > It seems that the dso->symsrc_filename can be NULL and it's unsafe to > call dwarf_find_debug_frame() with the NULL pointer. Other than that > looks good to me.
Thanks, I will change it to fallback to dso->name if dso->symsrc_filename is NULL.
| |