lkml.org 
[lkml]   [2015]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] perf: unwind: pass symbol source to libunwind
On Mon, Oct 12, 2015 at 02:35:08PM +0200, Namhyung Kim wrote:
> On Mon, Oct 12, 2015 at 8:24 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote:
> >> Even if --symfs is used to point to the debug binaries, we send in the
> >> non-debug filenames to libunwind, which leads to libunwind not finding
> >> the debug frame. Fix this.
> >>
> >> Signed-off-by: Rabin Vincent <rabin.vincent@axis.com>
> >
> > cc-ing Namhyung on this one
>
> It seems that the dso->symsrc_filename can be NULL and it's unsafe to
> call dwarf_find_debug_frame() with the NULL pointer. Other than that
> looks good to me.

Thanks, I will change it to fallback to dso->name if
dso->symsrc_filename is NULL.


\
 
 \ /
  Last update: 2015-10-13 13:01    [W:0.070 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site