Messages in this thread | | | Subject | Re: [PATCH v2 00/36] x86: Rewrite all syscall entries except native 64-bit | From | Richard Weinberger <> | Date | Mon, 12 Oct 2015 23:02:16 +0200 |
| |
Am 12.10.2015 um 20:41 schrieb Andy Lutomirski: > On Mon, Oct 12, 2015 at 11:30 AM, Richard Weinberger > <richard.weinberger@gmail.com> wrote: >> On Fri, Oct 9, 2015 at 3:06 PM, Ingo Molnar <mingo@kernel.org> wrote: >>> Ok, so I applied all of them to tip:x86/asm, in two phases, with small (stylistic) >>> edits - it all seems to work fine for me so far, so I pushed it all out to -tip >>> and linux-next. >>> >> >> FYI, this breaks the UML build: >> >> CC arch/x86/um/sys_call_table_64.o >> arch/x86/um/sys_call_table_64.c:49:1: error: unknown type name ‘sys_call_ptr_t’ >> const sys_call_ptr_t sys_call_table[] ____cacheline_aligned = { >> ^ >> arch/x86/um/sys_call_table_64.c:54:2: warning: initialization makes >> integer from pointer without a cast [enabled by default] >> [0 ... __NR_syscall_max] = &sys_ni_syscall, >> ^ >> arch/x86/um/sys_call_table_64.c:54:2: warning: (near initialization >> for ‘sys_call_table[0]’) [enabled by default] >> arch/x86/um/sys_call_table_64.c:54:2: error: initializer element is >> not computable at load time >> arch/x86/um/sys_call_table_64.c:54:2: error: (near initialization for >> ‘sys_call_table[0]’) >> >> Andy, I suspect UML's syscall.h needs the sys_call_ptr_t type too? >> > > Whoops, yes. UML has some weird casts in the syscall code that might > be removable with that change, too. Want to fix it or should I?
Please send a fix. I'll happily review/test it.
Thanks, //richard
| |