Messages in this thread | | | Date | Mon, 12 Oct 2015 09:29:10 +0200 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 3/5] ARM: shmobile: R-Mobile: add missing of_node_put |
| |
Dear Geert Uytterhoeven,
On Mon, 12 Oct 2015 09:18:52 +0200, Geert Uytterhoeven wrote:
> > pd = kzalloc(sizeof(*pd), GFP_KERNEL); > > - if (!pd) > > + if (!pd) { > > + of_node_put(np); > > return -ENOMEM; > > + } > > While technically this patch is correct, the system will be dead anyway if it > ever goes OOM at core_initcall() time.
Then BUG_ON(!pd); ?
Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |