Messages in this thread | | | Date | Mon, 12 Oct 2015 11:52:55 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 2/2] clk: tegra: delete unneeded of_node_put |
| |
On 10/09, Julia Lawall wrote: > for_each_child_of_node performs an of_node_put on each iteration, so > putting an of_node_put before a continue results in a double put. > > The semantic match that finds this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > iterator name for_each_child_of_node; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_get(child) > * of_node_put(child); > ... > * continue; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > ---
Applied to clk-next
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |