Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch issues | Date | Mon, 12 Oct 2015 17:22:29 +0000 |
| |
On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote: > Fix some checkpatch issues in "comedidev.h". There are still some > CamelCase warnings, but since those are for the use of "mA" and it > represents "milliamps", I think I'll leave them alone. > > 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex > 2) staging: comedi: comedidev.h: spaces preferred around that '*' > > drivers/staging/comedi/comedidev.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Ian,
Just a comment...
The checkpaatch.pl noise about "mA" defines are a bit annoying but I agree that those defines are clearer than "{foo}_milliamps".
But, even though they don't cause a CamelCase warning for some Reason, the "RANGE_ext" and "RANGE_unitless" could be renamed to "RANGE_EXT" (or RANGE_EXTERNAL for clarity) and "RANGE_UNITLESS". There is currently only 1 driver that uses RANGE_unitless and 5 that use RANGE_ext.
Regards, Hartley
| |