Messages in this thread | | | Date | Mon, 12 Oct 2015 10:25:51 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 0/2] staging: comedi: comedidev.h: fix some checkpatch issues |
| |
On Mon, Oct 12, 2015 at 05:22:29PM +0000, Hartley Sweeten wrote: > On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote: > > Fix some checkpatch issues in "comedidev.h". There are still some > > CamelCase warnings, but since those are for the use of "mA" and it > > represents "milliamps", I think I'll leave them alone. > > > > 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex > > 2) staging: comedi: comedidev.h: spaces preferred around that '*' > > > > drivers/staging/comedi/comedidev.h | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > Thanks! > > Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > Ian, > > Just a comment... > > The checkpaatch.pl noise about "mA" defines are a bit annoying but > I agree that those defines are clearer than "{foo}_milliamps".
I agree, checkpatch is just a "hint", feel free to ignore it when it says stupid things. Like this.
thanks,
greg k-h
| |